add : Project Euler 95 - solution #9169
Conversation
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
project_euler/sol1.py
Outdated
| Find the smallest member of the longest amicable chain with no element exceeding one million. | ||
| """ | ||
|
|
||
| def find_smallest_member(n : int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file project_euler/sol1.py, please provide doctest for the function find_smallest_member
Please provide descriptive name for the parameter: n
for more information, see https://pre-commit.ci
…/Python into add/project-euler-95
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def find_smallest_member(n: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file project_euler/sol1.py, please provide doctest for the function find_smallest_member
Please provide descriptive name for the parameter: n
for more information, see https://pre-commit.ci
…/Python into add/project-euler-95
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def find_smallest_member(n: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file project_euler/sol1.py, please provide doctest for the function find_smallest_member
Please provide descriptive name for the parameter: n
Describe your change:
This PR adds the solution of Project Euler - 95 problem
Fixes #9166
Checklist: